Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix temp table deletion causing runaway allocations #3278

Merged
merged 5 commits into from
Sep 8, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Sep 8, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request addresses an issue we've been having with runaway memory allocations causing stress on the garbage collector. For some reason, deleting temporary tables causes SQLite to flip out and keep allocating memory, which is then immediately cleaned up.

This PR fixes the issue by changing the way we delete temporary tables: for Postgres, we can just use ON COMMIT DROP, which causes the temp tables to be cleaned up when the transaction ends. For SQLite, we can adjust the max conn lifetime to 5 minutes to ensure that temp tables get closed when the connection is closed + recreated.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit b17010c into main Sep 8, 2024
3 checks passed
@tsmethurst tsmethurst deleted the temp_table_allocs_fix branch September 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant